Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractDonkeyEntity is misleading #3759

Open
NebelNidas opened this issue Dec 24, 2023 · 0 comments
Open

AbstractDonkeyEntity is misleading #3759

NebelNidas opened this issue Dec 24, 2023 · 0 comments

Comments

@NebelNidas
Copy link
Member

NebelNidas commented Dec 24, 2023 •
edited
Loading

It's extended by four classes:

  • DonkeyEntity,
  • LlamaEntity,
  • TraderLlamaEntity and
  • MuleEntity.

The class itself extends from AbstractHorseEntity, which has an additional set of implementers:

  • Horse
  • Skeleton Horse
  • Zombie Horse
  • Camel

My suggestions:

  • AbstractHorseEntity -> HorseLikeEntity
  • AbstractDonkeyEntity -> ChestCarryingHorseLikeEntity (the entire purpose of the subclass is to manage the chest's inventory data)

To be fair, the Like sounds a bit weird, even though it better communicates the purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NebelNidas