Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Boolean' is inconsistently shortened in serialization-related field names #4013

Open
haykam821 opened this issue Oct 7, 2024 · 0 comments · May be fixed by #4031
Open

'Boolean' is inconsistently shortened in serialization-related field names #4013

haykam821 opened this issue Oct 7, 2024 · 0 comments · May be fixed by #4031
Labels
bug Fixes or discusses a bug within the mappings

Comments

@haykam821
Copy link
Contributor

'Boolean' is shortened as 'bool' inconsistently within field names relating to serialization:

  • PacketCodecs.BOOL field
  • TrackedDataHandlerRegistry.BOOLEAN field

This inconsistency is most obvious when looking at the way the latter field is initialized:

public static final TrackedDataHandler<Boolean> BOOLEAN = TrackedDataHandler.create(PacketCodecs.BOOL);
@haykam821 haykam821 added the bug Fixes or discusses a bug within the mappings label Oct 7, 2024
Shnupbups added a commit to Shnupbups/yarn that referenced this issue Oct 22, 2024
@Shnupbups Shnupbups linked a pull request Oct 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes or discusses a bug within the mappings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant