Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File drop callback is incorrectly referred to as dragging #4015

Open
haykam821 opened this issue Oct 8, 2024 · 0 comments · May be fixed by #4031
Open

File drop callback is incorrectly referred to as dragging #4015

haykam821 opened this issue Oct 8, 2024 · 0 comments · May be fixed by #4031
Labels
bug Fixes or discusses a bug within the mappings

Comments

@haykam821
Copy link
Contributor

The Screen#filesDragged method is wrongly named, as it is called upon the dropping of files onto the window as opposed to the initial drag of files. This issue can be seen in the Mouse#onFilesDropped method:

private void onFilesDropped(long window, List<Path> paths, int invalidFilesCount) {
	this.client.getInactivityFpsLimiter().onInput();
	if (this.client.currentScreen != null) {
		this.client.currentScreen.filesDragged(paths);
	}

	if (invalidFilesCount > 0) {
		SystemToast.addFileDropFailure(this.client, invalidFilesCount);
	}
}
@haykam821 haykam821 added the bug Fixes or discusses a bug within the mappings label Oct 8, 2024
Shnupbups added a commit to Shnupbups/yarn that referenced this issue Oct 22, 2024
@Shnupbups Shnupbups linked a pull request Oct 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes or discusses a bug within the mappings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant