Add some inputs to vehicle_choreo_generic

[URAKOLOUY5]

Details

• SetMinPitch
• SetMaxPitch
• SetMinYaw
• SetMaxYaw

Used in Portal 2 to control ability of rotating camera in final game cutscene
Technically they use also SetCanShoot but I think it's net compat breaking change and requires a lot of changes to implement

[robotboy655]

I have added those but I have not tested them. Please test it on dev beta and let me know if it all works as expected.

UseAttachmentEyes input will not work for now, as it it requires net compatiblity changes.

[URAKOLOUY5]

Well uh
now it resets to vehicle position

Maybe now it's related to eyes attachment

Portal.2.2024.10.21.-.19.46.59.02_1.mp4

(i can't rotate camera by the way)

[robotboy655]

The changes are not live yet. You can see the live game commits on the official Discord server or https://commits.facepunch.com/r/garrysmod.main/main

[URAKOLOUY5]

Oh, odd that there's difference. Last time in x86-64 it just sticks looking up.
When I switched to dev branch - behavior from video

[URAKOLOUY5]

On x86-64

[URAKOLOUY5]

dev

Attacking don't work.
Camera it still broken as stated previously.

[robotboy655]

Can you tell me how to trigger whatever you are doing to test this?-

[URAKOLOUY5]

Like it's all part of gp2 addon

Just go to sp_a4_finale4, noclip into button room and see cutscene. It should work as is.

[robotboy655]

Alright, that helps, thanks, I will push some fixes later today for these issues.

[URAKOLOUY5]

It works very well.

Only my portal gun can't fire, but that's my problem, everything else is fine I think

[robotboy655]

I will keep this issue open for the network compatibility changes that need to be enabled at some point, as a reminder to do it.