Export CMAKEMOD dir #1560

dennisklein · 2024-06-14T09:45:37Z

Shall be backported to v19.0 and v18.8 as well.

coderabbitai · 2024-06-14T09:45:45Z

Warning

Rate limit exceeded

@dennisklein has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 46 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between bd68c0f and 60baa2d.

Walkthrough

The recent changes primarily entail updating copyright details and adding a new CMake variable for specifying the directory of project-specific CMake modules. There are no modifications to publicly exported entities, ensuring compatibility remains intact.

Changes

File	Change Summary
cmake/CMakeLists.txt	Updated copyright year and added `set` command for `PROJECT_CMAKE_MODULES_DIR`
cmake/private/FairRootConfig.cmake.in	Added `@PROJECT_NAME@_CMAKE_MODULES_DIR` declaration
cmake/private/FairRootPackage.cmake	Updated copyright year and added `PROJECT_CMAKEMOD_DIR` to `PATH_VARS` list

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

cmake/private/FairRootConfig.cmake.in

ChristianTackeGSI · 2024-06-14T10:15:57Z

Why this shortened name? Why not FairRoot_CMAKE_MODULES_DIR?

dennisklein · 2024-06-14T10:23:03Z

Why this shortened name? Why not FairRoot_CMAKE_MODULES_DIR?

Inherited from here I guess. I don't mind the longer one, if you prefer it.

ChristianTackeGSI · 2024-06-14T10:37:26Z

Why this shortened name? Why not FairRoot_CMAKE_MODULES_DIR?

Inherited from here I guess. I don't mind the longer one, if you prefer it.

Thanks for using the longer name. I think, it's more readable.

Looking at your linked find module

FairRoot/cmake/modules/FindFairRoot.cmake

Line 33 in fad0a30

set(FAIRROOTPATH "${FairRoot_PREFIX}")

I wonder, whether we should replace the FIND_PATH with something like this?

set(FAIRROOT_CMAKEMOD_DIR "${FairRoot_CMAKE_MODULES_DIR}")

dennisklein · 2024-06-14T10:40:55Z

Why this shortened name? Why not FairRoot_CMAKE_MODULES_DIR?

Inherited from here I guess. I don't mind the longer one, if you prefer it.

Thanks for using the longer name. I think, it's more readable.

Looking at your linked find module

FairRoot/cmake/modules/FindFairRoot.cmake

Line 33 in fad0a30

set(FAIRROOTPATH "${FairRoot_PREFIX}")

I wonder, whether we should replace the FIND_PATH with something like this?
set(FAIRROOT_CMAKEMOD_DIR "${FairRoot_CMAKE_MODULES_DIR}")

Hmm, possibly yes. But only once the new exported variable here is actually released. As the FindFairRoot.cmake file is copied by users, such a refactoring will need to be done conditionally on the found FairRoot version.

ChristianTackeGSI · 2024-06-14T10:47:52Z

Maybe something like this?

if(FairRoot_CMAKE_MODULES_DIR)
  set(FAIRROOT_CMAKEMOD_DIR "${FairRoot_CMAKE_MODULES_DIR}")
else()
  FIND_PATH(FAIRROOT_CMAKEMOD_DIR
    NAMES modules/FindFairRoot.cmake modules/ROOTMacros.cmake
    PATHS ${FAIRROOTPATH}/share/fairbase/cmake
  )
endif()

dennisklein · 2024-06-14T11:00:09Z

if(FairRoot_CMAKE_MODULES_DIR)
  set(FAIRROOT_CMAKEMOD_DIR "${FairRoot_CMAKE_MODULES_DIR}")
else()
  FIND_PATH(FAIRROOT_CMAKEMOD_DIR
    NAMES modules/FindFairRoot.cmake modules/ROOTMacros.cmake
    PATHS ${FAIRROOTPATH}/share/fairbase/cmake
  )
endif()

True, done. I made it a cache variable as that is what find_path() does:

//Path to a file.
FAIRROOT_CMAKEMOD_DIR:PATH=/home/dklein/projects/FairRoot/install/share/fairbase/cmake

@ChristianTackeGSI

Co-authored-by: @ChristianTackeGSI

dennisklein added this to the v18.8 milestone Jun 14, 2024

dennisklein requested a review from ChristianTackeGSI June 14, 2024 09:45

coderabbitai bot reviewed Jun 14, 2024

View reviewed changes

cmake/private/FairRootConfig.cmake.in Outdated Show resolved Hide resolved

dennisklein linked an issue Jun 14, 2024 that may be closed by this pull request

Export more FairRoot_*_DIR variables in the new CMake package #1548

Open

dennisklein force-pushed the export-modules-dir branch from 819307f to bd68c0f Compare June 14, 2024 10:28

dennisklein force-pushed the export-modules-dir branch from bd68c0f to 3f87507 Compare June 14, 2024 10:59

build: Export FairRoot_CMAKE_MODULES_DIR

60baa2d

Co-authored-by: @ChristianTackeGSI

dennisklein force-pushed the export-modules-dir branch from 3f87507 to 60baa2d Compare June 14, 2024 11:02

ChristianTackeGSI approved these changes Jun 14, 2024

View reviewed changes

ChristianTackeGSI merged commit 60baa2d into FairRootGroup:dev Jun 14, 2024
20 of 29 checks passed

ChristianTackeGSI modified the milestones: v18.8, v19.0 Jun 14, 2024

dennisklein deleted the export-modules-dir branch June 14, 2024 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export CMAKEMOD dir #1560

Export CMAKEMOD dir #1560

dennisklein commented Jun 14, 2024

coderabbitai bot commented Jun 14, 2024 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

ChristianTackeGSI commented Jun 14, 2024

dennisklein commented Jun 14, 2024

ChristianTackeGSI commented Jun 14, 2024

dennisklein commented Jun 14, 2024 •

edited

Loading

ChristianTackeGSI commented Jun 14, 2024 •

edited

Loading

dennisklein commented Jun 14, 2024

Export CMAKEMOD dir #1560

Export CMAKEMOD dir #1560

Conversation

dennisklein commented Jun 14, 2024

coderabbitai bot commented Jun 14, 2024 • edited Loading

Rate limit exceeded

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

ChristianTackeGSI commented Jun 14, 2024

dennisklein commented Jun 14, 2024

ChristianTackeGSI commented Jun 14, 2024

dennisklein commented Jun 14, 2024 • edited Loading

ChristianTackeGSI commented Jun 14, 2024 • edited Loading

dennisklein commented Jun 14, 2024

coderabbitai bot commented Jun 14, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

dennisklein commented Jun 14, 2024 •

edited

Loading

ChristianTackeGSI commented Jun 14, 2024 •

edited

Loading