Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent "Register" APIs and semantics in FairRootManager #1569

Open
dennisklein opened this issue Jun 27, 2024 · 0 comments
Open

Inconsistent "Register" APIs and semantics in FairRootManager #1569

dennisklein opened this issue Jun 27, 2024 · 0 comments
Labels
Refactor Code needs to be reworked

Comments

@dennisklein
Copy link
Member

There is another issue about branch IO of FairRootManger:

There are two different, independent branch registries: fAnyBranchMap and fMap. These are used by different APIs of FairRootManager:

  1. fAnyBranchMap is used by RegisterAny and InitObjectAs.
  2. fMap is used by Register and GetObject.

Any branch registered in one way cannot be read by another way.

What's even more "interesting" is that the event header (online run) is always registered in fMap but not in fAnyBranchMap. So you may find that you can get a valid event header from GetObject but mysteriously nullptr from InitObjectAs.

Originally posted by @YanzhaoW in #1557 (comment)

@dennisklein dennisklein changed the title Inconsistent "Register" APIs in FairRootManager Inconsistent "Register" APIs and semantics in FairRootManager Jun 27, 2024
@fuhlig1 fuhlig1 added the Refactor Code needs to be reworked label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Code needs to be reworked
Projects
None yet
Development

No branches or pull requests

2 participants