Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WLED Effects are not using color order from outputs. #1947

Open
CaffeinatedFunctionality opened this issue Sep 4, 2024 · 10 comments
Open

WLED Effects are not using color order from outputs. #1947

CaffeinatedFunctionality opened this issue Sep 4, 2024 · 10 comments
Assignees

Comments

@CaffeinatedFunctionality
Copy link

CaffeinatedFunctionality commented Sep 4, 2024

Steps to produce:

  1. Use a non RGB order light and set it to it's color order(BRG is what I am using)
  2. Run wled effect in scheduler using command
  3. Notice the RGB values are not being respected
@CaffeinatedFunctionality
Copy link
Author

Closing because I think this is user error on my part. If I notice it again I will reopen it.

@CaffeinatedFunctionality
Copy link
Author

Reopening after a lot of testing and confirmation from other users. When using the Overlay Model Effect, specifically with WLED effects, color order is not being respected. The other effects, bars, blink, color fade, and text, all use the correct color order. It's only the WLED ones that do not. I'm not sure if I can get to this one soon.

@CaffeinatedFunctionality CaffeinatedFunctionality changed the title Effects are not using color order from outputs. WLED Effects are not using color order from outputs. Sep 16, 2024
@CaffeinatedFunctionality
Copy link
Author

Closing. I think I misunderstood something

@coolguymatt
Copy link

Can you explain what you misunderstood? I feel like I have the same issue.

@CaffeinatedFunctionality
Copy link
Author

Yeah it's still happening. It seems like it doesn't always do it though. It's kind of annoying. I haven't had a chance to research deep into the issue though but it should be reopened. Sorry to keep doing this.

@patdelaney
Copy link
Contributor

It would be extremely helpful to the Dev team if you can attach a a sample xlights sequence and then the steps involved in "Run wled effect in scheduler using command" Which WLED effect. Screenshots and exact steps would be greatly appreciated.

If the developer can easily reproduce it, the chances of it getting fixed are significantly higher.

@CaffeinatedFunctionality
Copy link
Author

This is all about WLED no Xlights. Run WLED with a string with a color order that is not RGB. It's not following that color order. It makes it really hard to use the WLED commands and plugins because this isn't being followed in FPP.

Screenshot_20241013_092708_Chrome
20241013_092718

@chassy33
Copy link

I am also running into this issue. I am using Wally's WRGB floods. In xLights I set the color order and upload to controller. All my sequences use this config and no issues. But when using WLED effects in FPP the colors selected don't match what the floods show.

@dkulp
Copy link
Contributor

dkulp commented Jan 15, 2025

I'm fairly certain it's more of an issue with 4 channel than the order. I don't believe the PixelOverlayModel things handle anything other than 3 channel pixels at this point. There are areas in the code like "int c = (y * width * 3) + x * 3;" which is definitely tied to 3 channel.

@CaffeinatedFunctionality
Copy link
Author

Mine is a three Chanel with this issue. bgr order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants