Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] Mod incompatibility with Fusion causing crash with Create and potentially others #620

Closed
karelmikie3 opened this issue Feb 17, 2024 · 0 comments · Fixed by #706
Closed
Assignees
Labels
1.20 bug Something isn't working crash Issue involves a game crash.

Comments

@karelmikie3
Copy link

karelmikie3 commented Feb 17, 2024

First of all since this is a prerelease I understand that you don't have time to sort mod incompatibilities so it is fine if this doesn't get fixed right away. However, I have discovered an incompatibility with Fusion which causes a crash when combined with Create.

Mod versions:
PAUCAL: 0.6.0-pre-118
Hex: 0.11.1-7-pre-620
Caelus API: 3.1.0+1.20
Patchouli: 1.20.1-84
Create: 0.5.1.f
Fusion: 1.1.0c
Forge: 47.2.0

Here are the logs when all mods are used:
https://gist.github.com/karelmikie3/a9c4af832fa95070b20237c2ac87d341

Now for my solution and commentary:
Looking at the log it's easy to point out ForgeMixinDatagenModLoader. Looking at its code shows an overwrite mixin which could be incompatible with a similar mixin in Fusion. Changing it into an inject as done in #621 alleviates this issue.

I however, have some doubts about the necessity of this mixin entirely as looking at forge's code suggests that this code would behave identically with and without the mixin.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Hex Casting Feb 17, 2024
@SamsTheNerd SamsTheNerd added bug Something isn't working 1.20 labels Mar 9, 2024
@object-Object object-Object moved this from 📋 Backlog to 👀 In review in Hex Casting Mar 25, 2024
@object-Object object-Object added the crash Issue involves a game crash. label Jun 14, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Hex Casting Jul 23, 2024
Master-Bw3 pushed a commit to Master-Bw3/HexMod that referenced this issue Aug 29, 2024
Master-Bw3 pushed a commit to Master-Bw3/HexMod that referenced this issue Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 bug Something isn't working crash Issue involves a game crash.
Projects
Status: ✅ Done
4 participants