Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp Panel likely off-by-1 Error when Moving Files #884

Open
fitdev opened this issue Nov 24, 2024 · 2 comments
Open

Temp Panel likely off-by-1 Error when Moving Files #884

fitdev opened this issue Nov 24, 2024 · 2 comments
Labels

Comments

@fitdev
Copy link

fitdev commented Nov 24, 2024

Far Manager version

3.0.6074.0 x64

OS version

10.0.22621

Other software

No response

Steps to reproduce

  1. Search for files, and see the results in Temp such that it has at least 3 files.
  2. Select 2 files such that the first (0th) file at the very beginning (top) is not selected.
  3. F6 to move selected files to some folder

Expected behavior

Selected files get moved and are removed from the Temp panel.
ALL non-selected files remain in the Temp panel.

Actual behavior

Selected files get moved and are removed from the Temp panel (this is correct).
File immediately above the original selection is removed from the Temp panel (which is wrong - it should remain in the panel since it was not selected) but is not moved (which is correct - it was not selected, and therefore should have nothing happen to it).

Also it is possible that some other non-selected files are removed from the Temp panel as well, not just the one immediately above the selection. It may be especially the case when selection has gaps - perhaps all non-selected files that appear immediately before each selection fragment get removed from the Temp panel.

This looks like a typical off-by-1 error somewhere.

Also F6 Move was just an example, it may also likely happen with some other actions that would end up changing Temp Panel's contents.

@fitdev fitdev added the bug label Nov 24, 2024
@alabuzhev
Copy link
Contributor

@fitdev I cannot reproduce it.
6074 was almost two years ago, maybe it was fixed already, please try to update.
If that doesn't help, we will need more information, e.g. how the underlying directory structure looks like.

@fitdev
Copy link
Author

fitdev commented Nov 24, 2024

Thank you for looking into it so quickly.

I will update soon (I just was not comfortable using nightly builds so was delaying the update) and let you know if the issue is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants