Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the formal parameter of observation_factory #589

Open
lihua12312 opened this issue Apr 10, 2024 · 4 comments
Open

the formal parameter of observation_factory #589

lihua12312 opened this issue Apr 10, 2024 · 4 comments

Comments

@lihua12312
Copy link

屏幕截图 2024-04-10 102402

屏幕截图 2024-04-10 102205
Hello, I believe the formal parameter of observation_factory should be self.config rather than self.config['observation'], otherwise other key-value pairs in config will not be applicable to the observation space, such as vehicles_count.Could I confirm with you whether my understanding is incorrect?

@lihua12312
Copy link
Author

Sorry, I seem to have misunderstood. If I wish to update the parameters of the observation space, should I add key-value pairs to config['observation'] instead of changing the formal parameter to config? Is my understanding correct? I apologize for taking up your time.

@lihua12312
Copy link
Author

May I also ask, can the environment accommodate a point mass model?

@eleurent
Copy link
Collaborator

If I wish to update the parameters of the observation space, should I add key-value pairs to config['observation'] instead of changing the formal parameter to config?

Yes, that is correct.

May I also ask, can the environment accommodate a point mass model?

It can be adapted to. Right now the base class is RoadObject, which are motionless by default, and a child class is Vehicle which implements a Bicycle Model. But you can add a new RoadObject subclass which takes in commands/forces and updates the object's position/speed/heading etc.

@lihua12312
Copy link
Author

Thank you for your kind response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants