Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] FastForward MV3 on Firefox broken after AMO relisting #1130

Closed
Cynosphere opened this issue Sep 28, 2023 · 12 comments · Fixed by #1134
Closed

[Bug] FastForward MV3 on Firefox broken after AMO relisting #1130

Cynosphere opened this issue Sep 28, 2023 · 12 comments · Fixed by #1134
Labels
Breaking Change Users will have to manually update bug Something isn't working

Comments

@Cynosphere
Copy link

Body

FastForward does not work at all after updating after FastForward being relisted on AMO

Version

Manifest-v3

What browser(s) are you seeing the problem on?

Firefox browsers

What platform are you seeing the problem on?

Computer (Windows, Linux, MacOS)

Anything else?

I am not joining your Discord. Stop contributing to information voiding.

@runxel
Copy link

runxel commented Sep 28, 2023

Can confirm. The new version does nothing.

@MarkJGx
Copy link

MarkJGx commented Sep 28, 2023

What's "information voiding"?

@driedpampas
Copy link
Contributor

We are currently investigating this (and another issue with the version not showing up)

@lostdusty lostdusty added bug Something isn't working Breaking Change Users will have to manually update labels Sep 28, 2023
@lostdusty
Copy link
Contributor

We are aware of the issue already, and trying to get a fix for this.

Could you explain "information voiding", please?

@lostdusty lostdusty pinned this issue Sep 28, 2023
@Cynosphere
Copy link
Author

http://ascii.textfiles.com/archives/5509

@lostdusty
Copy link
Contributor

..what? we have documentation on github wiki, and we are working on the fix, but we didnt comment about anything with the public, until this issue, because we thought this was going to be a simple fix, but the way mozilla wants the consent dialog to be implemented make it a hard thing to fix

@undeadjess
Copy link
Member

update:
this is happening because Mozilla asked us to add a consent dialogue in the new version because of new rules they have about processing urls. they said we have to have the user press agree BEFORE running any code. unfortunately, the code that manages the consent page isn't working properly, so the extensions main code (the background script) isn't being run, so nothing is working.

#1134 may fix this, but needs testing. once that is done, we will upload the new fixed version to Firefox and hopefully this issue will be sorted

@driedpampas
Copy link
Contributor

driedpampas commented Sep 30, 2023

update:
We've identified possible problematic commits going back quite a bit

@driedpampas
Copy link
Contributor

another update:
we've identified the problematic code and are testing a fix

@lostdusty lostdusty linked a pull request Oct 1, 2023 that will close this issue
3 tasks
@lostdusty lostdusty unpinned this issue Oct 1, 2023
@escape0707
Copy link

escape0707 commented Oct 5, 2023

So, unless a new release is published to AMO, Firefox users still can't use this addon unless they install it manually somehow?

If so, is there any instruction about how to manually install git version of this addon?

@driedpampas
Copy link
Contributor

exactly or you can download the latest package zip file in actions (and if using firefox stable or beta, change the contact email in the manifest and upload it to firefox addons as self distributed so they sign it real quick so you can install it)

@escape0707
Copy link

As of recent update, it's working now.

(Although some Example Links on the homepage can't be bypassed, like the clictune.com one. But I think that belongs to another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Users will have to manually update bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants