FAIL_ON_MISSING_EXTERNAL_TYPE_ID_PROPERTY setting ignored when creator properties are buffered

[josephlbarnett]

#1341 added the ability to disable a FAIL_ON_MISSING_EXTERNAL_TYPE_ID_PROPERTY deserialization feature. However, it appears to only be observed through the complete(JsonParser p, DeserializationContext ctxt, Object bean) codepath, and is not examined in the complete(JsonParser p, DeserializationContext ctxt, PropertyValueBuffer buffer, PropertyBasedCreator creator) variant that gets used with, for example, @JsonCreator annoations.

It looks like adding the same check for prop.isRequired() || ctxt.isEnabled(DeserializationFeature.FAIL_ON_EXTERNAL_TYPE_ID_MISSING_PROPERTY)) immediately before calling ctxt.reportInputMismatch should allow the feature to work properly in this case?

Tested on jackson-databind 2.9.9

[josephlbarnett]

this may be the same issue reported in #1527, as we initially saw this working with kotlin classes. Attached PR fixes in our case and includes a test that demonstrates the issue with pure java classes.

[cowtowncoder]

Looks legit: thank you for contribution!

Quick question: have I asked for (and received) CLA yet? If not, it's at:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print, fill & sign, scan, email to info at fasterxml dot com.
Once I get it I'll merge the PR and it will be part of eventual 2.9.10 (as well as 2.10.0.pr2).
And I hope it'll help a lot with Kotlin module.

[josephlbarnett]

CLA emailed, thanks!