Fix introspector chaining in JaxbAnnotationIntrospector.hasRequiredMarker()
#32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say I have a property marked with
@JsonProperty(required = true)
.I also used
objectMapper.registerModules(ObjectMapper.findModules(classLoader))
to register modules but now the property is not considered "required".That's because there is a chain of
JaxbAnnotationIntrospector
andJacksonAnnotationIntrospector
(in this order) andJaxbAnnotationIntrospector.hasRequiredMarker()
returnsBoolean.FALSE
soJacksonAnnotationIntrospector
is not called (inAnnotationIntrospectorPair
).This PR fixes this case,
JaxbAnnotationIntrospector.hasRequiredMarker()
now returnsnull
so property can be processed by subsequent introspector.This PR also changes that
JaxbAnnotationIntrospector.hasRequiredMarker()
now authoritatively returnsBoolean.FALSE
when annotation is present. This behavior is consistent withJacksonAnnotationIntrospector
.