Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when the workspaces are empty. #96

Open
oaavahid opened this issue May 22, 2024 · 3 comments
Open

Issue when the workspaces are empty. #96

oaavahid opened this issue May 22, 2024 · 3 comments
Labels
fix Bug

Comments

@oaavahid
Copy link

Hello, and thanks for the nice extension.

When all the workspaces are empty, there is a "gear" icon appearing in workspace 1. After each update, I will have to apply a manual fix to extension.js to get rid of it. Perhaps, you could already fix this in the code. The following is the solution:

I added this additional line:
if (app.get_id().match(/window/i)) return false;

After this existing line:
const app = Shell.WindowTracker.get_default().get_window_app(win)

Thank you.

@Favo02
Copy link
Owner

Favo02 commented May 24, 2024

Thank you for the report.

Doesn't the Add application to ignore setting with the window regex filter out the "gear" icons? I currently cannot reproduce the issue, so please let me know if the filter doesn't work out.

image

@Favo02 Favo02 added the fix Bug label May 24, 2024
@oaavahid
Copy link
Author

I tried this some while ago but did not solve the issue. The problem was that window is followed by a number that is constantly changing. Thank you.

@Favo02
Copy link
Owner

Favo02 commented May 24, 2024

The setting field should support regex, so window[0-9]* should work, please let me know if this solves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug
Projects
None yet
Development

No branches or pull requests

2 participants