Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating lines at end of game (g1 20) #30

Open
gregorulm opened this issue Nov 15, 2019 · 0 comments
Open

Floating lines at end of game (g1 20) #30

gregorulm opened this issue Nov 15, 2019 · 0 comments

Comments

@gregorulm
Copy link

I noticed that there is potentially unintended behavior in G1 20G (possibly other modes, too). When you reach level 999 without becoming GM, the drop animation of the stack is not completed. In TGM1, this can only happen if you reach the GM title and at the end of the credit roll. When that credit roll is over, it simply freezes the stack at whatever state it is in, i.e. any blocks above the last line you cleared may or may not float. As a suggestion, I think that for aesthetic reasons, there should never be floating blocks at the game-over screen.

FeV, I know that you are currently taking a break from Shiromino, but I hope that you will eventually continue working on it as it is a wonderful piece of software.

Examples are below.

Shiromino, 1G 20G, 999 without GM:
Screen Shot 2019-11-15 at 12 16 12

TGM1, 999 without GM:
Screen Shot 2019-11-15 at 12 15 48

TGM1, 999 with GM (floating blocks):
Screen Shot 2019-11-15 at 12 18 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant