-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQUEST] Option to keep stalled torrents. #84
Comments
This is doable, shouldn't be terrible to implement. At first I'll implement this using a tag, proceeding from there I'll make the changes for the This change will also need to adjust the search behaviour as currently qBitrr only searches for items that aren't in the queue for Radarr/Sonarr |
Dang dude you're awesome. Check your Patreon messages, by the way. |
This specific issue should be resolved currently in docker tag |
Great and thank you. I tested it out with each of the following:
and
Looks like it's just ignoring the new settings outright. According to the logs, it's qBitrr v4.7.5-7c72ac4 When I have it create the config.rename_me, it does in fact have the new Hope this helps! |
The version number for now will remain the same, only the hash will change, until the change is completed. Can you set logs to trace and send over a log? |
If not tonight, tomorrow, I'll be doing some testing myself too |
Whoops shoulda had that for you already. Here are the logs: qBitrr Logs The one I'm looking at is Lionheart. By the way, the reason I can keep reusing Lionheart is because even though qBitrr keeps adding it to the blocklist and multiple entries at that, it seems like Radarr is ignoring the blocklist and re-adding it to qbittorrent everytime. Funny thing is in an interactive search, it DOES show the blocklisted icon. Was gonna bring it up later as an issue but didn't want to complicate things. Just mentioning right now in case you were wondering how I'm using the same torrent test over and over. |
The reason for grabbing the same torrent is due to use of multiple trackers which would have the same torrent. For Radarr/Sonarr each torrent on each tracker is different, so this happens a lot |
Also, let the trace logs run for 15-30 mins before sending them over. There's no info to work with in the logs you sent me |
OK, I let it run for about an hour: qBitrr Logs SHould show it replacing Lionheart every 30 minutes. |
I went over everything and it just dawned on me. Can you test again tagging the torrent with the new tag |
Made some additional changes, kindly update your container and test again please |
If you can send me the magnet link to the Lionheart torrent so I can test please |
OK all done. Same link: qBitrr Logs
Hope it helps! Oh and if you want a quicker response, I'm DevanteWeary on Discord. |
I noticed an issue in the logs you sent, I'll fix it and hopefully the logic will be functional |
Update to the latest version, I think it is now resolved and functional. Once confirmed I'll push the official update and continue work on the tagless update |
Though remind me, you wanted a search to still occur if the torrent is stalled right? |
OK. I did the same update. Forced updated the pr-86 tag. This time I tried three scenarios so there are three sets of logs: qBitrr Logs Here's what happened: logs_minus_one_no_tag:
logs_zero_no_tag:
logs_zero_using_tags:
Also, with Anchorman, I noticed it will remove the stalled torrent, add it to blocklist, and re-add a new torrent that has a bunch of seeders and actively downloads (desired behavior). Then if I pause it, it'll get removed on the next loops (which I set to 5 minutes). One more thing, each time I tested, I removed all the blocklist entries as well. Oh and I let them run for a while. At least 30 minutes each time I think. OK that's it for now! |
I just had another movie downloading, had plenty of seeds and was actively downloading. Just on a hunch, I ran qBitrr and sure enough, it removed that torrent, blocklisted it, and re-searched it. And I forgot to answer you... Yeah what I was looking for originally is for it to go ahead and blocklist and re-search stalled torrents. |
Noted, have you tried with a price value for a delay? Say 60 (minutes)? |
Otherwise I think I can have this ready by Sunday at the most (maybe Monday) |
I just tried with 3600 (1 hour) and it just did the same thing. Removed torrent (ignoring the `StalledDelay = 3600'), blocklist, re-search (adding the same exact torrent, ignoring Radarr's blocklist). The odd thing about the blocklist situation is it seems like this is the only movie it's ignoring the blocklist for. I'll do some more testing on that front, but seems like a Radarr issue. If you ever want to remote into my server and see what it's doing in realtime, just let me know here or Discord (DevanteWeary). |
Noted, I've made some changes and added more logs. I'm also testing this functionality with the Lionheart torrent you provided and things seem to be working correctly now. Please update and let me know, trace logs are now clearer on what the new functionality is doing |
Also the delay is in minutes, so 3600 would be equal to 60 hours. I've updated the config description |
OK updated the pr_86 again and still didn't work.
Also note how the last time Lionheart we removed and re-searched, it was at 54% so was actively downloading. It stalls at about 94ish%. Oh and I changed the |
I also tested out some other movies: Bad Moms and Wayne's World.
Then re-searched those as well. So to sum up, the current issues are:
That's it! |
Ok so going through your logs I can deduce the following: The What's definitely wrong is the processing of paused torrents, that I'll need to adjust for sure |
That's what I understood. In other words, if a torrent is only 57 minutes old, it will not be removed/replaced IF I haven't looked at those logs in particular but I can tell you it's ignoring the 60 minutes rule for sure. And remember, it was ignoring the setting even when I had it set to 60 hours too. Sorry man I know you've been working hard on it. I did one quick test just now. Here's a screenshot of a second or two before it removed Lionheart, and then a screenshot of the log right after. And of course the actual logs. |
Can you send me your config again please to check a few things? And logs too. Also sorry for the delayed reply, had a hectic weekend |
Ignore the previous message, I found the logs. I made some changes (logging updates too) and the crashing error should be fixed, take another look please. Also delay -1 seems to be working correctly. I do plan on seeing how to add timestamps at some point but it hasn't been an issue given that actions which are time dependant are logged appropriately. use |
OK, updated to nightly and here's what I got. tldr;
-- [ Delay 0 - Untagged ] -- qBitrr Logs -- [ Delay 0 - Tagged ] -- qBitrr Logs -- [ Delay 1440 - Mixed ] -- qBitrr Logs |
Ok so I reopened a PR to handle things better for updates so use Overall the only incorrect behaviour I found was the paused download status handling. If you manually tag a torrent the logic won't work correctly as the torrent is blocked and researched only when the tag is added, not if it already there (to avoid blocklisting and researching on every loop run). Otherwise, besides the paused download, it seems to me that the expected behaviour was correct, please correct me if I am wrong. |
Hey just to make sure, do you want me to use About the manual tagging... OK I actually didn't understand that before so thank you! If so, the issue it seems to be having goes back to the original intent of this feature request: it's removing stalled torrents from qBittorrent instead of keeping them. Current behavior:
Desired behavior:
So if I had to put it in options form, the desired behavior would look like this: |
Both are wrong actually, it's |
Regarding the removing of the torrent from qbittorrent when blocking, I'll investigate further, need to consult the Arr APIs |
Hey, came across this: line 43 Sorry if this is nothing, just saw it and wanted to throw it out there! |
After looking into pyarr (the arr api used by qBitrr) further, it seems that the delete queue isn't working as intended. After some manual tested I found a solution and have implemented it. Kindly update to the latest |
I think this last update should meet the desired behaviour, as such I have started work on the TAGLESS update and made a good amount of progress already |
Thank you so much for sticking with it!!! You're amazing man. Good news is it worked the first time, but bad news is after that, it stopped working and also did a couple things it didn't do before, like say it was blocking/researching but didn't actually do it. -- [ Delay 0 ] <-- Worked perfectly!!! - qBitrr Logs -- [ Delay 1440 ] - qBitrr Logs -- [ Delay 0 - IgnoreYoungerThan 1200 ] - qBitrr Logs -- [ Delay 0 - Added torrent after launching qBitrr ] - qBitrr Logs -- [ Delay 0 - Added torrent before launching qBitrr ] - qBitrr Logs -- [ Delay 0 - I Forced Update of qBitrr ] - qBitrr Logs aaaaaand I just tried a test... nothing special just wanted to since it's now hours later from those previous test... -- [ Delay 0 ] - qBitrr Logs |
Ok so after checking all the logs and logic, I determined that I think the test with the 1440 delay needed a restart or needed the update to work as intended (I have added logs to log the stalled delay value for this reason). In addition when having a 0 delay the skipping is intended if its already been processed or has no changes required, so that's normal (skipping means 'let it be' essentially. Lastly, the only real issue I saw was the not blocking and searching, I have made a small adjustment with added logs to hopefully fix the issue and if not at least better determine what's going on. So please UPDATE first, then test... Fingers crossed |
OK I wanna saaaay.... looking good so far! I don't know man, I wanna say delay0 is a success!
But for the intent of keeping stalled torrents while searching for new ones... looks like you got it working!! I wanted to ask... so I just assumed by removing the qBitManager folder, I was "starting fresh" i.e. removing the flag that said a torrent had already been check. But I don't think that's the case at all, is it? |
Very happy to hear, and regarding the researching, it'll only work if qBitrr itself tags the torrent, not if you do. You should never need to tag anything except for the ignore tag, but I'll take a look tomorrow before merging and getting down to having a function tagless version. Regarding your question about deleting the folder, the way qBitrr works, it doesn't really care about the folder, it rebuilds all the data it needs with every database update to keep up to date with the Arr apps. In short, restarting it is enough to literally start fresh with whatever configs you have set in your config.toml |
Also to clarify, stalled delay 20 means remove after 20 minutes from torrent added time of stalled. Some scenarios:
Re search happens when the torrent is tagged as stalled only, or when removed if it exists in the Arr app's queue |
Oh snap OK no I was totally mistaken. Well that's a cool option then. OK OK sorry one more thing. In qBittorrent, I don't think the status "Downloading metadata" is considered stalled even if it's been that way for a while. I see that those torrents show up in the Downloading filter and not the Stalled filter, so assuming that is relevant? |
I forgot the exact rule but after a while if a torrent is still stuck on downloading metadata, it should be detected as stalled yes, if not I'll amend it |
So just to clarify regarding the |
Just a follow up. |
Very happy to hear. Sorry on the delay for the tagless, been very busy lately and had to resolve some issues |
Trying to use this feature to prevent H&R but it seems to be deleting the stalled torrents right away. Am I doing something wrong? ReSearchStalled = true |
Did you restart qBitrr after changing these settings? And if so, please attach trace logs with this enabled. Thanks |
Closing due to no response |
Hey, touching on my questions from earlier, thought I'd make some suggestions here.
I don't know if you like 1 post per topic. Sorry if it seems like I'm spamming!
So this suggestion is:
Sort of like there's an option to never delete seeding torrents, have the same option for torrents when searching for new ones to replace.
It might look like this:
And the behavior would be:
This way, the old one has a chance to complete one day, but you still have qBitrr looking for new ones.
Some uses cases... sometimes there will be a torrent that has stalled for a week or two, but by the grace of the torrent gods, someone will connect with the rest.
I see there's the qbitrr-ignored tag, but that's not really the same thing I believe.
That just causes qBitrr to ignore that one being stalled if I'm not mistaken.
This would be super helpful for torrent from private trackers that are stalled.
If one is stalled, I don't want it delete because it'll probably give me a hit and run.
But still want qBitrr to look for a different release.
No delete. Just add! :P'
OK thank you!
The text was updated successfully, but these errors were encountered: