Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check auto-merge commit title #238

Open
AlekSi opened this issue Jan 23, 2024 · 0 comments
Open

Check auto-merge commit title #238

AlekSi opened this issue Jan 23, 2024 · 0 comments
Labels
code/feature Some feature is not implemented yet good first issue Good issues for new external contributors

Comments

@AlekSi
Copy link
Member

AlekSi commented Jan 23, 2024

// checkAutoMerge checks if PR's auto-merge is enabled.
func checkAutoMerge(_ *githubactions.Action, pr *graphql.PullRequest, community bool) error {
if pr.Closed || pr.AutoMerge {
return nil
}
msg := `PR should have auto-merge enabled.`
if community {
msg += ` Don't worry, maintainers will enable it for you.`
}
return errors.New(msg)
}

conform-pr's auto-merge checker should check that the commit_title property matches PR's subject number plus the PR number with # and brackets. That is to ensure that auto-merge generates the right commit subject line after the PR title is edited.

@AlekSi AlekSi added good first issue Good issues for new external contributors code/feature Some feature is not implemented yet labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some feature is not implemented yet good first issue Good issues for new external contributors
Projects
None yet
Development

No branches or pull requests

1 participant