Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update value and derivative deprecation message to make users aware of non-allocating batch evaluation #1125

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

termi-official
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (b8f986a) to head (d4e36f7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   93.57%   93.59%   +0.01%     
==========================================
  Files          39       39              
  Lines        6073     6087      +14     
==========================================
+ Hits         5683     5697      +14     
  Misses        390      390              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/deprecations.jl Outdated Show resolved Hide resolved
KnutAM
KnutAM previously approved these changes Jan 7, 2025
Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I don't think it is necessary to have the N and dNd\xi in green which simplifies a bit, but this will be removed after some time anyway (after a few releases I guess), so doesn't really matter much.

src/deprecations.jl Outdated Show resolved Hide resolved
src/deprecations.jl Outdated Show resolved Hide resolved
Co-authored-by: Knut Andreas Meyer <[email protected]>
@KnutAM KnutAM dismissed their stale review January 7, 2025 22:28

Realised that the function is not public, so let's discuss that before merging.

@fredrikekre fredrikekre merged commit db375ff into master Jan 10, 2025
16 checks passed
@fredrikekre fredrikekre deleted the do/values-derivatives-depwarn-batch branch January 10, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants