-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker vcs import with SSH key #162
Comments
Would changing vcs script address from |
Changing to the https address would sidestep the problem by using HTTPS instead of SSH for identity management and access control. That's probably ok for users since they're public repositories. Developers might find it annoying since they'd be required to enter their username and password to push commits back to the server (o manually change the remote addresses back to the git versions on their development machines). |
https://stackoverflow.com/questions/23391839/clone-private-git-repo-with-dockerfile
|
I've looked into this some and concluded that the original issue results from a VCS quirk. Because of the way that it's threaded, anything that requires user input wont work without a command-line flag that forces the whole VCS process to run in a single thread. In addition to slowing things down by ditching multi-threading, it also requires the user to enter their SSH key password for every single download. There's another potential workaround is to unlock the key for the Docker session (automating this is possible but a little clunky). We can talk about which (if any) approach we want to take at out next meeting. I think that @woensug-choi's post is describing is a slightly different manifestation of the larger VCS issue--forcing it to run as a single thread would probably fix what he's seeing, but automatically unlocking the SSH key would not. |
How about mounting ssh key when running the
|
@woensug-choi The directory containing the key is mounted already, but it still needs to be unlocked when the session starts. It's easy enough to do, but the command differs slightly depending on whether the user's key is RSA or ECC (and as you note, it assumes they have a key in the first place). |
vcs import from within the noetic docker image does not work with an SSH key. It repeatedly asks for the passphrase for the key in the .ssh directory but does not accept the correct passphrase. The git clones work correctly if they are done manually one at a time.
The text was updated successfully, but these errors were encountered: