Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the Virgil files that are used to new underwater vehicle tutorial? #270

Open
whoi-engineer opened this issue May 31, 2023 · 2 comments
Labels
to_be_discussed To be discussed at next group meeting.

Comments

@whoi-engineer
Copy link

whoi-engineer commented May 31, 2023

I've tried following the new underwater vehicle tutorial but I am hitting roadblocks. The tutorial would be easier to follow and then modify with ones own vehicle if the documents for the tutorial were actually on git. Is there something I'm missing?
There are also parts of the tutorial that I believe are no longer supported. For example:
<xacro:macro name="thruster_macro" params="thruster_id *origin"> <xacro:thruster_module_first_order_basic_fcn_macro namespace="$(arg namespace)" thruster_id="${thruster_id}" x_axis="0" y_axis="0" z_axis="1" mesh_filename="${prop_mesh_file}" dyn_time_constant="0.05" rotor_constant="0.00031"> <xacro:insert_block name="origin"/> </xacro:thruster_module_first_order_basic_fcn_macro> </xacro:macro>
if you include the parameters x_axis="0" y_axis="0 z_axis="1" then when you launch it tells you invalid parameters.

@mabelzhang
Copy link
Contributor

if the documents for the tutorial were actually on git

Are you referring to the tutorials for this repo? It is on Git: https://github.com/Field-Robotics-Lab/dave.doc (the GitHub repo name for GitHub IO pages are usually the last part of the URL)

@mabelzhang
Copy link
Contributor

Answering the title of the issue, the virgil files I believe are in a PR
#244

It was one of the last PRs for the project, and the project has since been out of funding. The PR has gone through a long review as you can see. Feel free to give it a try.

@mabelzhang mabelzhang added the to_be_discussed To be discussed at next group meeting. label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to_be_discussed To be discussed at next group meeting.
Projects
None yet
Development

No branches or pull requests

2 participants