Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed/Offer-Request Card - Share Icon #152

Open
Mohammedks713 opened this issue May 22, 2020 · 5 comments
Open

Feed/Offer-Request Card - Share Icon #152

Mohammedks713 opened this issue May 22, 2020 · 5 comments
Labels
2 - medium Level of effort is Medium

Comments

@Mohammedks713
Copy link
Collaborator

Note: this only refers to the Share Icon in the card and no other elements

-Paper place icon with no fill
-When user clicks on the Share Icon, a system Share screen will appear

image

@Mohammedks713 Mohammedks713 added this to the Feed/Offer-Request Card milestone May 22, 2020
@ethanswift
Copy link
Contributor

@devarshjoshi , @OnyekachiSamuel has already been worked on, available in the codebase, close the issue.

@OnyekachiSamuel OnyekachiSamuel added the 2 - medium Level of effort is Medium label May 24, 2020
@ethanswift
Copy link
Contributor

@OnyekachiSamuel this is also the same as heart button.

@devarshjoshi
Copy link
Collaborator

devarshjoshi commented May 26, 2020

Does the share functionality work? @ethanswift

@ethanswift
Copy link
Contributor

He, or someone else, has already made a generic class in which it takes each of heart button, share button and comment button and produces the view (the button). The functionality is defined later in the view controller itself, it doesn't makes any difference here. @devarshjoshi

@OnyekachiSamuel OnyekachiSamuel removed their assignment May 28, 2020
@devarshjoshi
Copy link
Collaborator

@ethanswift @OnyekachiSamuel whats happening on this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - medium Level of effort is Medium
Projects
None yet
Development

No branches or pull requests

4 participants