Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o-forms error summary: support inputs with no field title #899

Open
notlee opened this issue Nov 24, 2022 · 0 comments
Open

o-forms error summary: support inputs with no field title #899

notlee opened this issue Nov 24, 2022 · 0 comments
Labels
feature New feature request o-forms

Comments

@notlee
Copy link
Contributor

notlee commented Nov 24, 2022

o-forms creates an error summary based on field title. Sometimes an input is used without a field title,
such as this terms & conditions checkbox on the signup page.

To add error summary support for inputs which are not in a parent field
consider options such as:

  1. Should we require that a field title is provided but have a class to hide it (visually and to assistive tech)?
  2. Update error summary implementation to use a data attribute such as input[data-o-forms-error-summary-label] when a form input has no field.
  3. Something else?

Note: We can't use the input's label for the error summary because it reads "I confirm that I am..."
Note: We should always use the field title where given, and only use any new configuration option when an input is not part of a parent field. That's because a field can include multiple inputs with multiple errors, but we only show 1 error for a field in the error summary.

Captura de pantalla 2022-11-24 a las 14 19 58

@notlee notlee added feature New feature request o-forms labels Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request o-forms
Projects
None yet
Development

No branches or pull requests

1 participant