Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Digital Glitch will stop functioning correct with Media Source. Once you Hide/Show Media Source. #33

Closed
decors1 opened this issue May 26, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@decors1
Copy link

decors1 commented May 26, 2024

[Describe the bug]

If you Hide/Show Media Source, Digital Glitch no longer work until you reset filter settings.

[To Reproduce]

  1. add a "Media Source" probably any kind of videos.
    (also checked with image & Noise and both works fine.)
  2. add a "Retro Effects (Digital Glitch)" default is fine.
  3. hide and show Media Source.
  4. And the Digital Glitch stops functioning.

[Environment]

OS/Version: Windows 11
OBS Version: 30.1.2 (64bits)
Retro Effects: 0.0.10a

[GPU]

GPU make/model [RTX 4070]
GPU VRAM [12Gb]

@decors1 decors1 added the bug Something isn't working label May 26, 2024
@FiniteSingularity FiniteSingularity self-assigned this May 26, 2024
@FiniteSingularity
Copy link
Owner

I've got a fix for this one as well, in PR #35 . Issue was with the tick update- other sources when they are toggled off still report their dimensions as their original size. Media sources, since they stop playing, report their size as zero, and I was trying to assign/index a zero-size vector. You can check out the action build artifacts here if you want to test it: https://github.com/FiniteSingularity/obs-retro-effects/actions/runs/9243893741

@decors1
Copy link
Author

decors1 commented May 26, 2024

#35 soleved Media Source issue.
But Matrix Rain issues are not fixed yet. It’s behaving the same as last time.

PS. ah probably I must check with #34.
PS2. Both bugs are gone.!! ❤️

@FiniteSingularity
Copy link
Owner

Thanks for reporting these bugs and trying the PRs out. I'll merge it all in and cut a 0.0.11 bugfix pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants