Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Actual Localization Support #84

Open
Kvasenok opened this issue Sep 18, 2023 · 5 comments
Open

[Feature Request] Actual Localization Support #84

Kvasenok opened this issue Sep 18, 2023 · 5 comments

Comments

@Kvasenok
Copy link

Can we hope for the actual localization of the app and not just Readme? Maybe creating a project on crowdin could work?
It just seems based on the localized Readme's the community is willing to help.

@FireCubeStudios
Copy link
Owner

I have never made a localised app but I'm interested to try it on Protecc. I think I will have to push this for after v2 however

@Soboroo
Copy link
Contributor

Soboroo commented Oct 6, 2023

Actually, I've been working on it for a few weeks.
I implemented most of the i18n function but, there are a number of something to handle such as RTL support or the element's size adjustment due to the long strings.
Screenshot 2023-10-06 231704
Screenshot 2023-10-06 231858
Screenshot 2023-10-06 232654-1

And below is the Crowdin-GitHub integration setting. You can designate files that you want to translate as Resources.resw and README.md. If you want to add support language, add language at Crowdin and let it make translated files then that language will be added automatically in the selection combobox.
Screenshot 2023-10-06 233317
Screenshot 2023-10-06 233329

Test repo: https://github.com/Soboroo/Protecc/tree/crowdin
Crowdin: https://crowdin.com/project/protecctest

@FireCubeStudios
Copy link
Owner

This is actually amazing

@Kvasenok
Copy link
Author

Kvasenok commented Oct 6, 2023

It's more than amazing, it's progress 😃

@Soboroo
Copy link
Contributor

Soboroo commented Oct 18, 2023

I've resolved the long-string issue, but RTL will take a long time. I included the crowdin.yml file, so when you are ready to integrate with Crowdin, you can use it.

When you set up the Crowdin project, they will make a new branch. And when the project has been updated, they create PR for the original branch.

If you add a new string, you have to give a x:Uid to the element and then add that into resources.resw.

To add new support language, include a folder that contains resources.resw into the project.

About Localize strings

I recommend testing at another branch yourself. If you want to do, make a branch then I'll create a PR for that :)

I set this branch while assuming as before the Crowdin integration so if you want to set Crowdin from begin you can use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants