Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O'Neill shouldn't have access to ballistae, but does have access to ballistae. #536

Open
Huichelaar opened this issue Sep 24, 2023 · 1 comment
Labels
Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies.

Comments

@Huichelaar
Copy link
Contributor

If you add

BLST [6,22] 0x35

to the traps in Events/Release_map.event and start Boss Rush, O'Neill's danger radius implies he can access the ballista, even when his class and character structs have the relevant bit unset.

NO$GBA_2023-09-24_10-37-15

@masterofcontroversy
Copy link
Contributor

Looks like the cause of the issue is the range display code using r12/ip for a check ballista flag and expecting it to remain untouched through function calls.


@r0 has x, r1 has y, r2 has bitfield, r3 has halfword, r12 has ballista flag
push {r4-r7,r14}
mov r7,r8
push {r7}
mov r8,r12

In this particular case, GetInitialSkillList overwrites r12/ip while being used for testing range skills.

@sme23 sme23 added the Bug Issues pertaining to bugs. label Oct 13, 2023
@sme23 sme23 added the Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies. label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies.
Projects
None yet
Development

No branches or pull requests

3 participants