Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoted units not learning character level-up skills when loaded in. #556

Open
Huichelaar opened this issue Oct 27, 2023 · 0 comments
Open
Labels
Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies.

Comments

@Huichelaar
Copy link
Contributor

If a character level up skill is to be learned when loading a unit, this is done by setting the first byte of the short-sized entry in the skill list to 0xFF. However, if the unit is loaded in a promoted class this conditional branch is taken as r1 will be equal to 0xFE. This means the unit will not learn this skill. Is this intentional?

Reproduce by giving Seth a personal lvup skill list with an entry that has a skill with level=255 or 0xFF and putting a pointer to it in the char lvup table entry for Seth. Then, start a new game and check if Seth has the skill or not.

@sme23 sme23 added the Bug Issues pertaining to bugs. label Oct 27, 2023
@sme23 sme23 added the Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies. label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies.
Projects
None yet
Development

No branches or pull requests

2 participants