New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RandomMug and Capture hook in the same area. #573

Open

Huichelaar opened this issue Jan 2, 2024 · 0 comments

Labels

Core Features Enhancement

Contributor

Huichelaar commented Jan 2, 2024

RandomMug and Capture hook in the same area, is this intentional?

https://github.com/FireEmblemUniverse/SkillSystem_FE8/blob/master/EngineHacks/SkillSystem/Skills/UnitMenuSkills/Capture/Capture/Capture.event#L58
https://github.com/FireEmblemUniverse/SkillSystem_FE8/blob/master/EngineHacks/SkillSystem/Skills/MugLoadingSkills/RandomMug/RandomMug.event#L23

These two hooks overlap.

https://github.com/FireEmblemUniverse/SkillSystem_FE8/blob/master/EngineHacks/SkillSystem/Skills/UnitMenuSkills/Capture/Capture/Capture.event#L60
https://github.com/FireEmblemUniverse/SkillSystem_FE8/blob/master/EngineHacks/SkillSystem/Skills/MugLoadingSkills/RandomMug/RandomMug.event#L25

These two do as well.

Maybe it'd be better if there were a mugloading calcloop?

sme23 added the Enhancement label

sme23 added the Core Features label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment