Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaiden Magic Popup Bug #586

Open
ZeikoLeMonde opened this issue Feb 14, 2024 · 0 comments
Open

Gaiden Magic Popup Bug #586

ZeikoLeMonde opened this issue Feb 14, 2024 · 0 comments
Labels
Bug Issues pertaining to bugs. External Hacks Issues pertaining to external hacks that aren't a core part of the Skill System or its hooks.

Comments

@ZeikoLeMonde
Copy link

Due to the way SpellsGetterForLevel is written, when the function InitGaidenSpellLearnPopup calls it to check if the unit has learned a new spell, it doesn't properly check if the unit is promoted, which makes promoted units receive Popups for spells they actually learnt while unpromoted.
@sme23 sme23 added the Bug Issues pertaining to bugs. label Feb 15, 2024
@sme23 sme23 added the External Hacks Issues pertaining to external hacks that aren't a core part of the Skill System or its hooks. label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues pertaining to bugs. External Hacks Issues pertaining to external hacks that aren't a core part of the Skill System or its hooks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sme23 @ZeikoLeMonde