Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acrobat creating incorrect skill buffers #672

Open
Casdiss opened this issue Jun 12, 2024 · 0 comments
Open

Acrobat creating incorrect skill buffers #672

Casdiss opened this issue Jun 12, 2024 · 0 comments
Labels
Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies.

Comments

@Casdiss
Copy link

Casdiss commented Jun 12, 2024

In lines 10-14 of Acrobat.s, the active unit is loaded and checked for 0. If the active unit is 0, then r2 is mov’d to r0 and used as the unit argument instead.

the comment on line 14 says “if the active unit is 0, we're being called from dangerzone.” This erroneously assumes Acrobat is only called when a unit is selected or the danger zone is checked.

Acrobat is also checked every time there is a REDA in which case r2 contains an unrelated movement table. These REDA movement tables contain only FF and 01 and so in many scenarios will attempt to create a skill buffer for unit 01. If unit 01 is not yet loaded when a REDA occurs, it’ll create an empty skill buffer for them.

Since skill buffers are only regenerated if the unit being checked doesn’t already match the buffer, this can cause specifically unit 01 (usually the lord) to fail their next skill check if they are then loaded and tested fot skill.

To test, go to the skill buffer $2026BB0 during a REDA while unit 01 isn’t loaded. The skill buffer should become “01 00 00 00” Should unit then be loaded and tested for any skills, they will automatically fail them due to the pre-generated empty buffer.

@sme23 sme23 added Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies. labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues pertaining to bugs. Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies.
Projects
None yet
Development

No branches or pull requests

2 participants