Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load suggestions list in a more performant / user friendly way #38

Open
benbasson opened this issue Aug 25, 2014 · 0 comments
Open

Load suggestions list in a more performant / user friendly way #38

benbasson opened this issue Aug 25, 2014 · 0 comments

Comments

@benbasson
Copy link
Member

benbasson commented Aug 25, 2014

Currently we load suggestions in full - while the user waits - if there are up to 300 possible tags to choose from. If there are more than 300 possible tags, then suggestion list loading is performed asynchronously via a 300ms setTimeout. This has two downsides; the user has to wait and it's all very hardcoded, baked-in logic.

A better way to do this would be to always load the first 20 or 30 items, followed by a loading div in case the user ever reaches it by scrolling. We could then continue loading items asynchronously into the list and eventually remove the loading div.

If the user starts typing to filter, we should just cancel our processing at whatever point it got to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant