-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn "broken" items into a non tool item (like a stick) until repaired #111
Comments
Additional note: |
How should the items be repaired?
Option 1 should be implemented as it would tie in nicely with the current repair system but as it can be toggled off there must be another option for repairing. (I'd prefer option 2 as that would tie in nicely with modding the item) Idea on implementation: If UnbreakableItems is turned off the feature should be deactivated. The stick with a NBT-Tag (like BrokenMTitem: "DIAMOND_PICKAXE") could also be used to add textures to the broken items. |
Option 2 would be the most intuitive but option 3 would make sense too. |
The AnvilListener would be easier to implement as the crafting one, as you can not have a recipe with variable input and output or can you? |
Don't know, if it is still a good solution. (as it could be to complicated) |
when #150: could be part of the ItemManager |
Is your feature request related to a problem? Please describe.
Other plugins can behave weirdly with MT when items are "broken".
Causing duplication glitches (?) or other weird behaviour.
Describe the solution you'd like
Turn items into sticks or another non usable item when "broken".
When the item is repaired it turns back to the original item.
Describe alternatives you've considered
N/A
Additional context
I can see this working well when MT repair is used but I don't know how anvil repairing would work with this. We would probably have to manually listen to inventory clicks.
We'd also have to have ways of converting items to and from sticks.
I know vanilla has JSON serialization and deserialization for items.
We could probably go with that?
The text was updated successfully, but these errors were encountered: