Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valgrind detects leaks with still reachable memory #15

Open
Lecrapouille opened this issue Jan 12, 2018 · 3 comments
Open

valgrind detects leaks with still reachable memory #15

Lecrapouille opened this issue Jan 12, 2018 · 3 comments

Comments

@Lecrapouille
Copy link

Hi Florian ! I just discovered right now your lib ! Nice work ! It seems to Valgrind that there are missing calls to delete but memory can be released by the OS. I had no time for longer investigations but it seems to me:
1/ that exit() does not let class destructor to be called :( You have to create and call a release() method called by class destructor and to be called manually before your exit().
2/ disable_help() you call std::vector::erase() but you did not delete the command before.

@FlorianRappl
Copy link
Owner

Ho, did you look at #14?

@Lecrapouille
Copy link
Author

ooops no I did not ! My apologize for this double post :( ! I'll give a try ! Thx

@FlorianRappl
Copy link
Owner

No worries, maybe we can improve / work out a solution in #14. The exit is not a huge problem in my opinion (the OS will free the space anyway, if exit would not actually exit the situation would be different), but if it can be improved then even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants