You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi Florian ! I just discovered right now your lib ! Nice work ! It seems to Valgrind that there are missing calls to delete but memory can be released by the OS. I had no time for longer investigations but it seems to me:
1/ that exit() does not let class destructor to be called :( You have to create and call a release() method called by class destructor and to be called manually before your exit().
2/ disable_help() you call std::vector::erase() but you did not delete the command before.
The text was updated successfully, but these errors were encountered:
No worries, maybe we can improve / work out a solution in #14. The exit is not a huge problem in my opinion (the OS will free the space anyway, if exit would not actually exit the situation would be different), but if it can be improved then even better.
Hi Florian ! I just discovered right now your lib ! Nice work ! It seems to Valgrind that there are missing calls to delete but memory can be released by the OS. I had no time for longer investigations but it seems to me:
1/ that exit() does not let class destructor to be called :( You have to create and call a release() method called by class destructor and to be called manually before your exit().
2/ disable_help() you call std::vector::erase() but you did not delete the command before.
The text was updated successfully, but these errors were encountered: