Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce time taken to deploy a new snapshot #74

Open
knolleary opened this issue Apr 18, 2023 · 0 comments
Open

Reduce time taken to deploy a new snapshot #74

knolleary opened this issue Apr 18, 2023 · 0 comments
Labels
area:device Device specific work

Comments

@knolleary
Copy link
Member

When deploying a new snapshot we currently stop the existing flows, npm install the dependencies, then start the new flows.
Depending on how much work npm has to do, this can lead to prolonged downtime of the flows. We want to look at strategies for reducing this downtime to a minimum.

The npm cache work recently added is one way to skip the npm step - but that assumes you know ahead of time exactly what needs to be installed on the device and you lose some flexibility.

Other options we should consider:

  1. compare the new package.json with what's already there and skip the npm install step if everything appears in order. Need to assess how risky this is - we rely on npm to ensure everything is in order even though that takes a bit of time.
  2. look at what flags we passing to npm to minimise what its doing (production-only, skip audit etc)
  3. do not stop the existing flows until after npm install has completed and we're ready to run the new flows. This will require running the install in a clean directory (thereby losing some of efficiencies npm has when rerunning it in an existing dir, unless we clone node_modules first). This will need some investigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:device Device specific work
Projects
Status: No status
Development

No branches or pull requests

1 participant