-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment Variable Template Import #2372
Comments
Quick idea on changes to the env var page for how we could incorporate these: Screen.Recording.2023-06-30.at.11.03.24.movKey changes:
|
Can I work on this? @joepavitt @MarianRaphael |
We're actually going to have a pre-cursor to this which you're welcome to help out on: FlowFuse/forge-ui-components#56 We have a collection of custom-made widgets ( |
Actually, thinking about this further, we have no option to edit/delete env vars at the moment. Changing this to an "Edit Variables" button which toggles in text field inputs for the values and adds delete options too. @knolleary is there API functionality for that already, or would that increase scope to API changes too? |
@joepavitt Users can edit/delete env vars in their instance settings. There are the set of platform-defined ones ( |
🤦 right you are Nick, only had the |
Q1: It is common for # general
NODE_ENV=development
# promotions database
DB1_USERNAME=X
DB1_PASSWORD=X
DB1_HOST=X
# stock database
DB2_USERNAME=X
DB2_PASSWORD=X
DB2_HOST=X
# Stripe API key
PK=XYZ Would we wish to maintain this format for the user? I can certainly see a benefit of free text entry / free text edit (for ease and speed of editing and for the built in comments) but this would remove the custom elements and replace it with simpler text area. Q2: Are there any objections to adding the Q3: Multiline env vars are common and supported in dotenv files. e.g: PRIVATE_KEY="-----BEGIN RSA PRIVATE KEY-----
...
Kh9NV...
...
-----END RSA PRIVATE KEY-----" Do we
Q4: dotenv can support variable expansion. This can be added now or later (or never) but is a simple and very nice feature.
NOTE: Indicate in support (or no support) in docs to clarify the stance. FYI (and to teach the sucking of eggs), variable expansion permits this kind of thing: MONGOLAB_DATABASE=heroku_db
MONGOLAB_USER=username
MONGOLAB_PASSWORD=password
MONGOLAB_DOMAIN=abcd1234.mongolab.com
MONGOLAB_PORT=12345
MONGOLAB_USER_RECURSIVELY=${MONGOLAB_USER}:${MONGOLAB_PASSWORD}
MONGOLAB_URI_RECURSIVELY=mongodb://${MONGOLAB_USER_RECURSIVELY}@${MONGOLAB_DOMAIN}:${MONGOLAB_PORT}/${MONGOLAB_DATABASE}
MONGOLAB_URI=mongodb://$MONGOLAB_USER:$MONGOLAB_PASSWORD@$MONGOLAB_DOMAIN:$MONGOLAB_PORT/$MONGOLAB_DATABASE
MONGOLAB_USERPASS=$MONGOLAB_USER:$MONGOLAB_PASSWORD
MONGOLAB_URI2=mongodb://$MONGOLAB_USERPASS@$MONGOLAB_DOMAIN:$MONGOLAB_PORT/$MONGOLAB_DATABASE |
Q1: The requirement is to provide a simple way to import en masse a set of env vars. The imported file can contain comments, but those comments don't get saved anywhere - we store env vars as key/value pairs. Q2: Sure Q3: Our env var UI doesn't support multi-line env vars as they are presented as Q4: variable expansion is out of scope for this item. We haven't had any requests to support it. |
@knolleary forgot to ask what the merge rules are to be (I have scanned the issue but dont see it in the acceptance criteria or comments). Q1: When an env var upload is performed,
Q2: How to we perform any merges and conficts?
My chosen direction unless otherwise advised
|
|
Implements changes outlined in #2372
Verified on staging. These videos demonstrate the capacities and expectation - may be useful for future reference. Apologies, no voice over (just some mouse wiggles) OutlineEach import demonstration shows
Importing env var file into a devices environmentenv-var-import-on-device.mp4Importing env var file into an instances environmentenv-var-import-on-instance.mp4Importing env var file into a templateenv-var-importing-in-template.mp4 |
Description
As a Node-RED developer and FlowForge user,
I want to directly import environment variable templates,
So that I can minimize manual work and human error during the maintenance and input of environment variables.
Which customers would this be available to
All Users (CE)
Acceptance Criteria
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate
The text was updated successfully, but these errors were encountered: