Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot Management for Devices at Application Level #2609

Closed
4 tasks
Tracked by #2334
MarianRaphael opened this issue Aug 17, 2023 · 7 comments · Fixed by #2831, #2738 or #2750
Closed
4 tasks
Tracked by #2334

Snapshot Management for Devices at Application Level #2609

MarianRaphael opened this issue Aug 17, 2023 · 7 comments · Fixed by #2831, #2738 or #2750
Assignees
Labels
feature-request New feature or request that needs to be turned into Epic/Story details priority:high High Priority size:XL - 8 Sizing estimation point
Milestone

Comments

@MarianRaphael
Copy link
Contributor

MarianRaphael commented Aug 17, 2023

Description

As soon as Devices can be assigned to applications (without being linked to an Instance). The follow-up question is where to manage and "store" the created Snapshots:

Snapshots at Device Level:

Since Snapshots are currently managed at the Instance Level, the list of snapshots created for each device should be available only for that specific device at Device level. To promote snapshots to other devices, DevOps Pipelines would need to be extended as a subsequent step.

Not in scope:
Snapshots at Application level:

See discussion here: #2335

Tasks

  • Implementation of a snapshot overview tab for Devices, analogous to Instances.
  • Re-use table ProjectSnapshots for snapshot storage, but will require a new column to identify ownerType. At this iteration, that will be null, "device" or "instance". projectId field will be re-used for "device ID". If possible/viable, rename field to ownerId.
  • When a Device is unassigned from an Application and reassigned to an Instance, either a warning that the snapshots will be deleted should exist, or (better) the possibility to merge the snapshots in the instance list should be available.
  • Possibility to create snapshots for a standalone device.

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@MarianRaphael MarianRaphael added feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do size:XL - 8 Sizing estimation point labels Aug 17, 2023
@MarianRaphael MarianRaphael added this to the 1.12 milestone Aug 26, 2023
@knolleary knolleary removed the needs-triage Needs looking at to decide what to do label Aug 30, 2023
@MarianRaphael MarianRaphael added the priority:high High Priority label Aug 31, 2023
@Steve-Mcl Steve-Mcl moved this from Todo to In Design in 🛠 Development Sep 4, 2023
@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Sep 4, 2023

target audience: @knolleary @MarianRaphael @joepavitt

Q1

Implementation of a snapshot overview tab for Devices, analogous to Instances.

Would we expect to see the "Snapshots" tab when a device is bound to an instance too? In exploring the design today, it doesnt really fit. For example, following the figma,

I currently have this in my design work:

Image


Q2

Possibility to create snapshots for a standalone device.

When an instance has no snapshots, the empystate permits snapshot creation.

Image

However, currently, a device needs to be in developer mode to create a snaphot and that is done from the developer section on the overview:

Image

And lastly, the figma drawings show snapshot creation under a new Developer Mode tab:

Image

How should I reconcile this? What is the immediate conclusion/iteration please?

@joepavitt
Copy link
Contributor

Will address all of this tomorrow from a UX perspective

@joepavitt
Copy link
Contributor

Realise this comment would have been better served here, but just linking for reference.

@Steve-Mcl
Copy link
Contributor

FAO @knolleary @MarianRaphael

There is currently no concept of audit log at application level. Much of the snapshotting and its related audit logs are directed to the project scope auditing.

It may well be out of scope for this particular task, but it is something that will be need to be assessed / implemented. Should there be a task or new story around this?

Thoughts please?

@knolleary
Copy link
Member

Should there be a task or new story around this?

Yes please - it is a new task that should be raised and tracked separately.

@joepavitt
Copy link
Contributor

joepavitt commented Sep 5, 2023

It is a new task that should be raised and tracked separately.

It's already been raised: #1978

@Steve-Mcl
Copy link
Contributor

Verified on staging

device-snapshots.mp4

@Steve-Mcl Steve-Mcl moved this from Verify to Done in 🛠 Development Sep 28, 2023
@MarianRaphael MarianRaphael moved this from Short to Closed / Done in ☁️ Product Planning Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request that needs to be turned into Epic/Story details priority:high High Priority size:XL - 8 Sizing estimation point
Projects
Archived in project
4 participants