Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display false as a cross or empty checkbox #82

Open
Pezmc opened this issue Oct 24, 2022 · 5 comments
Open

Display false as a cross or empty checkbox #82

Pezmc opened this issue Oct 24, 2022 · 5 comments
Labels
task A piece of work that isn't necessarily tied to a specific Epic or Story.

Comments

@Pezmc
Copy link
Contributor

Pezmc commented Oct 24, 2022

Story

No response

Description

DataTables currently show check marks for any true values found in a cell (added in
8ce2a33 as part of #31)

However, it's potentially visually confusing that false is shown as a blank cell.

Screenshot 2022-10-24 at 12 46 03

False should be visible in some form, In this comment @Steve-Mcl and I suggested some options:

Screenshot 2022-10-24 at 13 08 36

@Pezmc Pezmc added task A piece of work that isn't necessarily tied to a specific Epic or Story. needs-triage Needs looking at to decide what to do labels Oct 24, 2022
@joepavitt
Copy link
Collaborator

joepavitt commented Oct 25, 2022

Agreed - the X would be my expectation, although may get too busy and more difficult to differentiate between the tick/cross.

In a table of 100 users, where we want to quickly identify the Admin, it wouldn't as easy to do so.

@joepavitt
Copy link
Collaborator

Also, I would only expect true/false values to appear in a column where there are those two values as the only options - do we know of cases where this isn't true?

@Steve-Mcl
Copy link
Contributor

I dont know of any explicit places Joe but even if there are no places with mixed data, there are still 3 states with bools - it may be valid to display them accordingly.

  • false : []
  • true : ☑️
  • undefined/null : blank

@Steve-Mcl
Copy link
Contributor

the X would be my expectation, although may get too busy and more difficult to differentiate between the tick/cross.

Also, on some OS, a check is signified by a X so dont think that is best idea. Especially since a page full of false may get mistaken for trues.

Most OS use a check outline [] to signify false (ref)

image

@joepavitt
Copy link
Collaborator

Outline box suggests something interactive, i.e. a checkbox. The thing we are emphasising with our true/false values currently are the true values - as such I am in favour of (for now) leaving it with a tick only.

@knolleary knolleary moved this to Unplanned in ☁️ Product Planning Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
Status: No status
Development

No branches or pull requests

3 participants