Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] yarn.lock is incorrectly .gitignored, potentially leading to build failures #1731

Closed
saevarb opened this issue Feb 15, 2024 · 1 comment
Labels
in-work Issue in work

Comments

@saevarb
Copy link

saevarb commented Feb 15, 2024

Describe the bug
Currently, yarn.lock is gitignore, which it shouldn't. In my fork, which I originally made a few months ago, a lockfile was created automatically. Updating the fork to match the new main branch means my lockfile is now incorrect, which (in my particular scenario) leads to build failures in OpenAIAssistant.ts because the openai version is not correct. This is just one example of a problem that can happen when no lockfile is present.

Expected behavior
The lockfile should be includede as part of the repository.

@HenryHengZJ
Copy link
Contributor

when we switch to pnpm, a frozen lockfile will be provided - #1272

@HenryHengZJ HenryHengZJ added the in-work Issue in work label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-work Issue in work
Projects
None yet
Development

No branches or pull requests

2 participants