Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dynamic Postgres Metadata Filtering via Agent State #3545

Open
sirsimonson opened this issue Nov 21, 2024 · 2 comments
Open

[BUG] Dynamic Postgres Metadata Filtering via Agent State #3545

sirsimonson opened this issue Nov 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@sirsimonson
Copy link
Contributor

sirsimonson commented Nov 21, 2024

Describe the bug

The metadata filter for Retriever Tool does not work with Postgres Metadata Filtering when used with the new dynamic filtering feature via agent state. (#3501) The filter is not passed down to the Postgres query, resulting in an unfiltered response.

To Reproduce

Configure a metadata filter for Retriever Tool using the new dynamic filtering feature.
Observe that filters are not applied as described in the PR.
Expected behavior
The metadata filter should correctly apply to the Postgres query and return filtered results.

image

Additional context

Filters configured as "Postgres Additional Metadata Filter" works currently in "Test Retrieval Query" Playground but fail when dynamically added as "Additional Metadata Filter" to the Retriever Tool.

@sirsimonson sirsimonson changed the title [BUG] [BUG] Postgres Metadata Filtering via Agent State Nov 21, 2024
@sirsimonson sirsimonson changed the title [BUG] Postgres Metadata Filtering via Agent State [BUG] Dynamic Postgres Metadata Filtering via Agent State Nov 21, 2024
@sirsimonson
Copy link
Contributor Author

@HenryHengZJ Please describe how this could be verified/tested...
image
I've logged the vectorstore instance used and it seems to have the correct "filter" property attached. shouldn't this be the same as "Additional Metadata" for Postgres Node itself?

@HenryHengZJ HenryHengZJ added the bug Something isn't working label Nov 24, 2024
@HenryHengZJ
Copy link
Contributor

I've tried it on Pinecone and it works. Will test it on PG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants