Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag named 'Header' breaks Media UI tag list #94

Closed
pKallert opened this issue Oct 14, 2021 · 4 comments
Closed

Tag named 'Header' breaks Media UI tag list #94

pKallert opened this issue Oct 14, 2021 · 4 comments
Labels
Bug Something isn't working

Comments

@pKallert
Copy link
Contributor

Description

I am not sure if this is a GraphQl Error or a Media UI Error, but it is an error and I think it is a very bad error.
The GraphQL used in the MediaUI seems to try to call tag and collection names as functions and this makes the MediaUI angry.
There is already a BugTicket in the t3n GraphQL Repository for that, see t3n/graphql#35
Perhaps the Media UI could somehow catch that and/or use a custom resolver? At least something that does not directly call a string as a function if the function exists.
This is not strictly a MediaUI issue, but nothing is happening over at the GraphQL issue and this is breaking my Media UI Tags a lot. Also, this feels really bad.

Steps to Reproduce

  1. Add a Tag named "Header" in the old MediaBrowser
  2. Open the Flowpack Media UI

Expected behavior

The Tags are shown.

Actual behavior

Tags are not shown and there is a JS Error [GraphQL error]: Message: Exception in line 33 of /application/Data/Temporary/Development/SubContextBeach/SubContextInstance/Cache/Code/Flow_Object_Classes/t3n_GraphQL_Service_DefaultFieldResolver.php: header() expects at most 3 parameters, 4 given - See also: xxx.txt, Location: [object Object], Path: tags

Affected Versions

Neos: 7.3

UI: 0.6.2

@Sebobo
Copy link
Member

Sebobo commented Oct 14, 2021

Thx for reporting. Will try to get in touch with Johannes to fix the underlying issue. Don't really want to built a workaround.

@Sebobo Sebobo added the Bug Something isn't working label Jan 17, 2022
@Sebobo
Copy link
Member

Sebobo commented Jan 17, 2022

Hi @pKallert,

updating to the GraphQL lib https://github.com/t3n/graphql/releases/tag/3.0.2 should fix that. Can you verify?

@pKallert
Copy link
Contributor Author

@Sebobo works locally in my project 👍
Should I update the composer file or should we leave it as it is?

@Sebobo Sebobo closed this as completed in 96114fa Jan 18, 2022
@Sebobo
Copy link
Member

Sebobo commented Jan 18, 2022

I bumped the minimum version. Thx for the help.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants