Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename_checkpoint.py -- concat_statfile -- time bug #210

Open
SCharlwood opened this issue Aug 24, 2018 · 1 comment
Open

rename_checkpoint.py -- concat_statfile -- time bug #210

SCharlwood opened this issue Aug 24, 2018 · 1 comment

Comments

@SCharlwood
Copy link

Hi,

I was using the rename_checkpoint script and noticed that there was an issue that occurred when appending data that changes order of magnitude.

For example if the simulation was stopped at 95s and the restarted simulation ran to a time of 150s it would only append data where the recorded time is less than 100s.

The function appends all data from the checkpoint stat files where the recorded time is 'larger' than the last time on the original stat file. The issue is that the time is stored in standard form and concat_statfile extracts and stores time as a string, it then evaluates using this string. When logically comparing strings python would determine the following to be true:
"0.99979164887571699E+002" > "0.10004628322103638E+003"

@Patol75
Copy link
Contributor

Patol75 commented Aug 27, 2018

Hi,

Can you confirm that converting the strings to floats solves the issue ? Either way lines 161 and 170, or line 171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants