Fix vae_mnist model #267
Merged
Fix vae_mnist model #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Is generation fine or producing grey images? |
|
Just grey images |
|
Runs without issues and resulting images are ok now. It could use some improvement overall, but I think we should just leave it like this for now. |
hinneburg
added a commit
to hinneburg/model-zoo
that referenced
this pull request
Feb 1, 2021
In vae_plot.jl the sigmoid needs to be applied to the sampled output from the decoder. Otherwise, the generated image `output/manifold.png` is corrupted. ``` julia --project vae_plot.jl ┌ Warning: Mapping to the storage type failed; perhaps your data had out-of-range values? │ Try `map(clamp01nan, img)` to clamp values to a valid range. └ @ ImageMagick ~/.julia/packages/ImageMagick/0LwpT/src/ImageMagick.jl:180 ``` The gnome image viewer reports: Fatal error reading PNG image file: PNG unsigned integer out of range. The error was caused by the commits in FluxML#267 that removed the sigmoid from last the decoder layer to enable the use of the more numerically stable logitbinarycrossentropy. However, only the output in [vae_mnist.jl](https://github.com/hinneburg/model- zoo/blob/b0aaf6950580976f9e84c6acd409f3018f8df7f5/vision/vae_mnist/vae_mnist.jl#L160) were adapted.
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also #266