Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make components instances instead of static classes #17

Open
jwir3 opened this issue May 10, 2020 · 0 comments
Open

Make components instances instead of static classes #17

jwir3 opened this issue May 10, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jwir3
Copy link
Contributor

jwir3 commented May 10, 2020

It would be really nice if we could make the components be actual instances, one per element, instead of classes containing a bunch of static methods. We could start this refactoring by taking a look at PasswordRevealIndicator, since that needs a little TLC anyway, and it wouldn't cause a break in the hierarchy chain.

I think what we should do is have every component derive from a superclass, Component, so that we can control some of this common behavior in a polymorphic way.

@jwir3 jwir3 added the enhancement New feature or request label May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant