Unfinished inline citation (?? something) hangs the script

[hazzik]

No description provided.

[FokkeZB]

Could you provide an example?

[hazzik]

Just go to the website and type “?? Anything”

…

On Tue, 17 Oct 2017 at 6:50 PM, Fokke Zandbergen ***@***.***> wrote: Could you provide an example? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI1l85zgUMbVEeH0SGTFETCbu0omrNKks5stEA6gaJpZM4P7S66> .

[FokkeZB]

Sorry, can't reproduce hanging the script:

[hazzik]

I'm able to reproduce this constantly. Thee are several conditions:

• ?? shall be at the beginning of a line
• It shall be not at the end of the file
  

[hazzik]

Easiest way to reproduce is

1. Open http://j2m.fokkezb.nl/
2. On line 15 select "citation??" (without first ??")
3. Press "delete"/"backspace"

[hazzik]

I can constantly reproduce this in latest Chrome and Firefox on Windows 10 and MacOS and on node 8.7
It does not hang in Safari and Mobile Safari

[FokkeZB]

Yep, with that I can reproduce, so it seems the issue is related to other stuff in the editor as well.

Unfortunately it indeed hangs, with no logs to aid debugging it further.

I'm also kind of iceboxing this project. If you have time to dig in and send a PR that would be appreciated.

[hazzik]

The culprit is at regex which parses the citation.