Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOODON is injecting axioms into CHEBI causing incoherencies #154

Closed
cmungall opened this issue Aug 2, 2021 · 7 comments
Closed

FOODON is injecting axioms into CHEBI causing incoherencies #154

cmungall opened this issue Aug 2, 2021 · 7 comments

Comments

@cmungall
Copy link
Contributor

cmungall commented Aug 2, 2021

FOODON is injecting an axiom "vitamine E" subClassOf 'food soluble vitamin'. In CHEBI these are structures and roles respectively. This causes incoherency when FOODON and CHEBI are combined. FOODON alone masks this as you are rewiring the chebi role to be a structure

https://www.ebi.ac.uk/ols/ontologies/foodon/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FCHEBI_24020&viewMode=All&siblings=false

image

I think this was originally reported here #42 but that was closed

@cmungall
Copy link
Contributor Author

cmungall commented Aug 2, 2021

It looks like this was discussed in an issue over here with very many comments: CompositionalDietaryNutritionOntology/cdno#57

That issue has many interesting points, however, it is absolutely imperative that we don't inject axioms that cause incoherencies. I realize the CHEBI labels are very confusing. However, the fix is not to rewire. This just bundles up a pandora's box full of incoherencies that break downstream ontologies. Just use the CHEBI classes in a way that is consistent with their logical classification.

See also OBOFoundry/OBOFoundry.github.io#1443

@ddooley
Copy link
Collaborator

ddooley commented Aug 3, 2021

CDNO led a call over a month ago with a CHEBI curator to straighten out their role and chemical entity branches for vitamins (there will be two branches, and role branch will have "role" explicit in labels. As soon as CHEBI publishes their August release we (FoodOn and CDNO) will be able to align with their terms and the problem should be solved downstream in FoodOn.

Right now FoodOn is importing CDNO "dietary nutrition component" that has CHEBI vitamin as a subclass - indeed it is a role and so that's the problem. But apparently the new, needed CHEBI terms are just days or weeks away from being released.

@ddooley
Copy link
Collaborator

ddooley commented Oct 4, 2021

Just awaiting an OntoBee/OntoFox update for new CHEBI so we can import changes and then make correction.

@ddooley
Copy link
Collaborator

ddooley commented Nov 15, 2021

Still waiting - a different OntoBee refresh bug is preventing latest CDNO from being loaded.

@cmungall
Copy link
Contributor Author

can you use robot?

@ddooley
Copy link
Collaborator

ddooley commented Nov 17, 2021

This should be fixed now. OntoBee just updated CDNO which had the CHEBI fix in it; FoodOn has now imported this and has a release.

@ddooley
Copy link
Collaborator

ddooley commented Dec 13, 2021

I'll close this; reopen if still an issue somehow.

@ddooley ddooley closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants