Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FunctionInfo immutable #489

Open
ForNeVeR opened this issue Nov 23, 2023 · 0 comments
Open

Make FunctionInfo immutable #489

ForNeVeR opened this issue Nov 23, 2023 · 0 comments
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors kind:refactor Internal changes not affecting the compiler behavior status:help-wanted Open for contributors

Comments

@ForNeVeR
Copy link
Owner

The current form of Cesium.CodeGen.Contexts.Meta.FunctionInfo is confusing: it is an immutable record struct, but with several mutable fields.

Let's make it fully immutable.

While we are at it, remove TODO[#489] from the code.
@ForNeVeR ForNeVeR added area:compiler Related to code compilation or type checking kind:refactor Internal changes not affecting the compiler behavior good-first-issue An issue considered simple enough for new contributors status:help-wanted Open for contributors labels Nov 23, 2023
ForNeVeR added a commit that referenced this issue Nov 23, 2023
@ForNeVeR
(#78, #285, #487, #488, #489, #490, #491, #492) Connect TODOs with th…
b76311e 
…e issues
@lightlessdays lightlessdays mentioned this issue Dec 8, 2023
Closed
@evgTSV evgTSV mentioned this issue Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors kind:refactor Internal changes not affecting the compiler behavior status:help-wanted Open for contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ForNeVeR