Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit conv.i in pointer interop only when necessary #491

Open
ForNeVeR opened this issue Nov 23, 2023 · 0 comments
Open

Emit conv.i in pointer interop only when necessary #491

ForNeVeR opened this issue Nov 23, 2023 · 0 comments
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors kind:feature New feature or request status:help-wanted Open for contributors

Comments

@ForNeVeR
Copy link
Owner

After implementing #354, we now have a feature that calls C# functions with CPtr, VoidPtr, and FuncPtr in their signatures. To call them, it will always emit a conv.i instruction.

This instruction is not always required (actually, in most cases it isn't): it should only be emitted when the value on stack is not a pointer.

We should fix that, and only emit it when necessary. See TODO[#491] when implementing.
@ForNeVeR ForNeVeR added kind:feature New feature or request status:help-wanted Open for contributors area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors labels Nov 23, 2023
ForNeVeR added a commit that referenced this issue Nov 23, 2023
@ForNeVeR
(#78, #285, #487, #488, #489, #490, #491, #492) Connect TODOs with th…
b76311e 
…e issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors kind:feature New feature or request status:help-wanted Open for contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ForNeVeR