Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-object-properties #88

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

Titozzz
Copy link
Contributor

@Titozzz Titozzz commented Aug 14, 2023

Following #86, I've noticed that replacing object properties should also be prevented to avoid issues.

Before, this would crash:

const test = {};
test.__DEV__; // with __DEV__: false

@Titozzz
Copy link
Contributor Author

Titozzz commented Aug 24, 2023

gentle nudge @gksander 😅

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for the nudge, I must not have seen this one come through!

@gksander
Copy link
Contributor

@Titozzz will you add a patch changeset record to this with yarn changeset and push that up? With that in place, we can get this merged and released ASAP!

@Titozzz
Copy link
Contributor Author

Titozzz commented Sep 19, 2023

@gksander All good, sorry for the delay!

@gksander gksander merged commit 2263e0c into FormidableLabs:master Sep 19, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
@gksander
Copy link
Contributor

Thanks once again @Titozzz! This change has been released as version 2.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants