add option to hide "Number" tooltip (#277)

Author: PhilippImhof

lang/en/qtype_formulas.php

@@ -342,6 +342,8 @@
 $string['settings_heading_general_desc'] = '';
 $string['settings_heading_width'] = 'Default widths';
 $string['settings_heading_width_desc'] = 'Default width of input fields for the various answer types. For fields that are left empty, the settings from the plugin\'s style file will be used. Please use this settings carefully. Making the fields too small can make it difficult for your students to type their answer. Note that the exclamation mark icon shown for invalid answers takes up approximately 12 pixels.';
+$string['settingshownumbertooltip'] = 'Show "Number" tooltip';
+$string['settingshownumbertooltip_desc'] = 'Whether the tooltip indicating "Number" should be shown for that answer type. It might make sense to not show that tooltip, e. g. when working with children in elementary schools. This setting does not affect tooltips for other answer types or for combined fields.';
 $string['subqoptions'] = 'Unit settings';
 $string['subqtext'] = 'Part\'s text';
 $string['subqtext_help'] = 'Part text and placement of answer fields can be specified here. The placeholders that can be used to specify answer fields places are:

renderer.php

@@ -595,14 +595,24 @@ protected function create_input_box(qtype_formulas_part $part, $answerindex,
             'data-answertype' => ($answerindex === self::UNIT_FIELD ? 'unit' : $part->answertype),
             'data-withunit' => ($answerindex === self::COMBINED_FIELD ? '1' : '0'),
 
-            'data-toggle' => 'tooltip',
-            'data-title' => $title,
-            'data-custom-class' => 'qtype_formulas-tooltip',
             'title' => $title,
             'class' => "form-control formulas_{$titlestring} {$feedbackclass}",
             'maxlength' => 128,
         ];
 
+        // If the answer type is "Number" and it is not a combined field, we only add the tooltip, if the
+        // corresponding option is set.
+        $iscombined = $inputattributes['data-withunit'] === '1';
+        $isnumber = !$iscombined && $inputattributes['data-answertype'] === qtype_formulas::ANSWER_TYPE_NUMBER;
+        $shownumbertooltip = get_config('qtype_formulas', 'shownumbertooltip');
+        if (!$isnumber || $shownumbertooltip) {
+            $inputattributes += [
+                'data-toggle' => 'tooltip',
+                'data-title' => $title,
+                'data-custom-class' => 'qtype_formulas-tooltip',
+            ];
+        }
+
         if ($displayoptions->readonly) {
             $inputattributes['readonly'] = 'readonly';
         }

settings.php

@@ -40,6 +40,14 @@
         0
     ));
 
+    // Whether the tooltip for answer type "Number" should be shown.
+    $settings->add(new admin_setting_configcheckbox(
+        'qtype_formulas/shownumbertooltip',
+        new lang_string('settingshownumbertooltip', 'qtype_formulas'),
+        new lang_string('settingshownumbertooltip_desc', 'qtype_formulas'),
+        1
+    ));
+
     // Default delay for the on-the-fly validation's debounce timer.
     $settings->add(new admin_setting_configselect(
         'qtype_formulas/debouncedelay',

tests/behat/tooltips.feature

@@ -95,3 +95,28 @@ Feature: Display of tooltips
     And I press shift tab
     Then I should not see "Number"
     And "div.tooltip-inner" "css_element" should not exist
+
+  Scenario: Tooltip for Number is not shown if disabled
+    When the following config values are set as admin:
+      | shownumbertooltip | 0 | qtype_formulas |
+    And I follow "Quiz 1"
+    And I press "Attempt quiz"
+    And I set the field "Answer" to "1"
+    Then I should not see "Number"
+    And "div.tooltip-inner" "css_element" should not exist
+
+  Scenario: Setting does not affect tooltip for combined field with answer type "Number"
+    When the following config values are set as admin:
+      | shownumbertooltip | 0 | qtype_formulas |
+    And I follow "Quiz 3"
+    And I press "Attempt quiz"
+    And I set the field "Answer" to "5 m/s"
+    Then I should see "Number and unit"
+
+  Scenario: Setting does not affect tooltip for other answer types
+    When the following config values are set as admin:
+      | shownumbertooltip | 0 | qtype_formulas |
+    And I follow "Quiz 2"
+    And I press "Attempt quiz"
+    And I set the field "Answer" to "x"
+    Then I should see "Algebraic formula"