fix some of the failing unit tests

Author: PhilippImhof

classes/local/answer_parser.php

@@ -93,9 +93,6 @@ public function is_acceptable_for_answertype(int $type, bool $acceptempty = fals
         if (count($this->tokenlist) === 1 && $firsttoken->type === token::EMPTY) {
             return $acceptempty;
         }
-        if (empty($this->tokenlist)) {
-            return $acceptempty;
-        }
 
         if ($type === qtype_formulas::ANSWER_TYPE_NUMBER) {
             return $this->is_acceptable_number();

tests/evaluator_test.php

@@ -133,7 +133,8 @@ public static function provide_invalid_diff(): array {
             ['The first argument of diff() must be a list.', 'diff("", "");'],
             ['The second argument of diff() must be a list.', 'diff([1,2,3], 1);'],
             ['diff() expects two lists of the same size.', 'diff([1,2,3], [1,2]);'],
-            ['When using diff(), the first list must contain only numbers or only strings.', 'diff([[1,2]], [1]);'],
+            ['When using diff(), the first list must contain only numbers or only strings.', 'diff([[1,2]], [[1,2]]);'],
+            ['diff(): type mismatch for element #0 (zero-indexed) of the second list.', 'diff([[1,2]], [1]);'],
             ['diff(): type mismatch for element #1 (zero-indexed) of the first list.', 'diff([1,"a"], [1,2]);'],
             ['diff(): type mismatch for element #1 (zero-indexed) of the first list.', 'diff(["a",1], ["a","b"]);'],
             ['diff(): type mismatch for element #0 (zero-indexed) of the second list.', 'diff([1,2], ["a",2]);'],

tests/question_test.php

@@ -955,7 +955,7 @@ public function test_summarise_response_threeparts(): void {
         $summary2 = $q->parts[2]->summarise_response($response);
         self::assertEquals('7', $summary2);
         $summary = $q->summarise_response($response);
-        self::assertEquals('5, 6, 7', $summary);
+        self::assertEquals('5; 6; 7', $summary);
     }
 
     public function test_summarise_response_test1(): void {
@@ -973,7 +973,7 @@ public function test_summarise_response_test1(): void {
         $summary3 = $q->parts[3]->summarise_response($response);
         self::assertEquals('50', $summary3);
         $summary = $q->summarise_response($response);
-        self::assertEquals('30m/s, 20, m/s, 40, 50', $summary);
+        self::assertEquals('30m/s; 20, m/s; 40; 50', $summary);
     }
 
     public function test_is_complete_response_test3(): void {