Prepare release 5.1.1 (#68)

Author: PhilippImhof

CHANGES.md

@@ -1,5 +1,13 @@
 # Changelog
 
+### 5.1.1 (2023-01-30)
+- bugfix: fmod() now works like in other scientific calculators
+- bugfix: sort() now uses natural sorting and does not lose values anymore
+- bugfix: instantiation check could fail in certain cases
+- internal: some cleanup, update of package.json
+
+Please note: future releases will no longer support Internet Explorer.
+
 ### 5.1.0 (2022-11-23)
 - added support for Moodle 4.1
 - new functions for number conversion (decimal <-> octal/binary)

classes/output/mobile.php

@@ -15,7 +15,7 @@
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
 /**
- * Mobile output class for qtype_gapfill
+ * Mobile output class for qtype_formulas
  *
  * @package    qtype_formulas
  * @copyright  2022 Jakob Heinemann
@@ -24,8 +24,6 @@
 
 namespace qtype_formulas\output;
 
-
-
 defined('MOODLE_INTERNAL') || die();
 
 /**
@@ -37,7 +35,7 @@
  */
 class mobile {
     /**
-     * Returns the gapfill question type for the quiz in the mobile app.
+     * Returns the Formulas question type for the quiz in the mobile app.
      *
      * @return void
      */
@@ -53,4 +51,4 @@ public static function mobile_get_formulas($args) {
             'javascript' => file_get_contents($CFG->dirroot . '/question/type/formulas/mobile/mobile.js')
         ];
     }
-}
+}

mobile/mobile.js

@@ -14,39 +14,38 @@
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
 /**
- * support for the mdl35+ mobile app. PHP calls this from within
+ * support for the Moodle mobile app >= 3.9.5. PHP calls this from within
  * classes/output/mobile.php
  */
-/* jshint esversion: 6 */
-/* eslint-disable no-console */
 
 var that = this;
 var result = {
     componentInit: function() {
         var div = document.createElement('div');
         div.innerHTML = this.question.html;
-        this.question.text = this.CoreDomUtilsProvider.getContentsOfElement(div, '.qtext');
+        this.question.text = div.querySelector('.qtext').innerHTML;
 
         // Replace Moodle's correct/incorrect and feedback classes with our own.
-        this.CoreQuestionHelperProvider.replaceCorrectnessClasses(div);
-        this.CoreQuestionHelperProvider.replaceFeedbackClasses(div);
+        that.CoreQuestionHelperProvider.replaceCorrectnessClasses(div);
+        that.CoreQuestionHelperProvider.replaceFeedbackClasses(div);
+        that.CoreQuestionHelperProvider.treatCorrectnessIcons(div);
 
-         // Treat the correct/incorrect icons.
-        this.CoreQuestionHelperProvider.treatCorrectnessIcons(div);
+        if (typeof this.question.text === 'undefined') {
+            return that.CoreQuestionHelperProvider.showComponentError(this.onAbort);
+        }
 
         if (div.querySelector('.readonly') !== null) {
             this.question.readOnly = true;
         }
+
         if (div.querySelector('.feedback') !== null) {
             this.question.feedback = div.querySelector('.feedback');
             this.question.feedbackHTML = true;
         }
 
-        if (typeof this.question.text == 'undefined') {
-            this.logger.warn('Aborting because of an error parsing question.', this.question.name);
-            return this.CoreQuestionHelperProvider.showComponentError(this.onAbort);
-        }
         return true;
     }
 };
+
+/* eslint-disable-next-line */
 result;

package.json

@@ -1,14 +1,13 @@
 {
        "name": "moodle-qtype_formulas",
        "devDependencies": {
-              "grunt": "^1.0.1",
-              "grunt-contrib-less": "^1.4.1",
-              "grunt-contrib-watch": "^1.0.0",
-              "grunt-load-gruntfile": "0.0.2"
+              "grunt": "^1.5.3",
+              "grunt-cli": "^1.4.3",
+              "grunt-contrib-watch": "^1.1.0"
        },
        "repository": {
               "type": "git",
-              "url": "git://github.com/dbauer-ets/moodle-qtype_formulas.git"
+              "url": "git://github.com/FormulasQuestion/moodle-qtype_formulas.git"
        },
        "license" : "GPL-3.0"
 }

thirdpartylibs.xml

@@ -7,4 +7,11 @@
         <license>MIT</license>
         <licenseversion></licenseversion>
     </library>
+    <library>
+        <location>tabulator.css</location>
+        <name>Tabulator</name>
+        <version>5.4</version>
+        <license>MIT</license>
+        <licenseversion></licenseversion>
+    </library>
 </libraries>

version.php

@@ -25,7 +25,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 $plugin->component = 'qtype_formulas';
-$plugin->version   = 2023010800;
+$plugin->version   = 2023012900;
 
 $plugin->cron      = 0;
 $plugin->requires  = 2017111300;